Skip to content

refactor(libanki): finish removing AnkiDroid dependencies from TestClass#18911

Merged
david-allison merged 2 commits intoankidroid:mainfrom
david-allison:libanki-testclass-4
Jul 18, 2025
Merged

refactor(libanki): finish removing AnkiDroid dependencies from TestClass#18911
david-allison merged 2 commits intoankidroid:mainfrom
david-allison:libanki-testclass-4

Conversation

@david-allison
Copy link
Member

I split this out from #18813 to make it an easier review

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

These have no AnkiDroid dependencies
Once moved to `libanki`, references will be broken

'ioDispatcher' is an AnkiDroid-level concern
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine David.

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 18, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 18, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Jul 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2025
@david-allison david-allison added this pull request to the merge queue Jul 18, 2025
Merged via the queue into ankidroid:main with commit b862fce Jul 18, 2025
13 of 14 checks passed
@github-actions github-actions bot added this to the 2.22 release milestone Jul 18, 2025
@david-allison david-allison deleted the libanki-testclass-4 branch July 18, 2025 15:16
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants